• Joined on 2025-01-27
Karutoh pushed to oop at Karutoh/Compiler 2024-02-15 15:47:49 -08:00
ecf6f0512d Changed call to symTab.SetEntries(SYMH_SIZE)
Karutoh pushed to oop at Karutoh/Compiler 2024-02-15 05:05:08 -08:00
53a7e6b37d Reduced complexity and added the capability of adding symbols.
Karutoh pushed to oop at Karutoh/Compiler 2024-02-15 01:01:52 -08:00
8d23df86bf Fixed potential bug with program fileSize field.
Karutoh created pull request Karutoh/Compiler#1 2024-02-14 23:40:27 -08:00
Moved Over To OOP to Abstract ELF Binary Generation
Karutoh pushed to oop at Karutoh/Compiler 2024-02-14 23:39:41 -08:00
669b6d66a3 Finished OOP conversion.
c3eb95e8f3 Backup.
Compare 2 commits »
Karutoh created branch oop in Karutoh/Compiler 2024-02-14 23:39:41 -08:00
Karutoh pushed to main at Karutoh/Compiler 2024-02-14 18:43:43 -08:00
7952710b65 Fixed include error?
Karutoh pushed to main at Karutoh/Compiler 2024-02-14 18:15:12 -08:00
81b3d6a08d Updated README.
Karutoh pushed to main at Karutoh/Compiler 2024-02-14 18:12:01 -08:00
637361432a Updated README.
Karutoh pushed to main at Karutoh/CustomHeapManager 2024-02-14 18:08:18 -08:00
f341253aa8 Merge pull request 'gbowne1 version of implementation with more implementations done' (#4) from gbowne1_impl into main
3305ef401c oops forgot the last of the changes
f83a00f4d5 Merge remote-tracking branch 'origin/main' into gbowne1_impl
fe9d9e3836 fixing issues from PR
19b2e31119 gbowne1 version of implementation with more implementations done
Compare 5 commits »
Karutoh merged pull request Karutoh/CustomHeapManager#4 2024-02-14 18:08:17 -08:00
gbowne1 version of implementation with more implementations done
Karutoh pushed to main at Karutoh/Compiler 2024-02-14 18:07:08 -08:00
37773da094 Updated README.
Karutoh pushed to main at Karutoh/Compiler 2024-02-14 18:06:01 -08:00
91f9086ef4 Organized and documented the code more.
Karutoh pushed to main at Karutoh/Compiler 2024-02-14 15:59:48 -08:00
2cafa2a2ce Removed Vulkan dependency.
Karutoh suggested changes for Karutoh/CustomHeapManager#4 2024-02-14 15:44:23 -08:00
gbowne1 version of implementation with more implementations done

This is not an error. The changes of struct block* b = (struct block*)ptr - 1; to struct block *b = (struct block *)((char *)ptr - BLOCK_SIZE); adds more text to parse for the compiler and just looks ugly. Both do the same thing.

Karutoh commented on pull request Karutoh/CustomHeapManager#4 2024-02-14 15:39:19 -08:00
gbowne1 version of implementation with more implementations done

In my_custom_free there's an error on line number 232 for the statement if (b == last). The last global variable was not updated prior to that statement, which in turn the statement will…

Karutoh commented on pull request Karutoh/CustomHeapManager#4 2024-02-14 15:25:36 -08:00
gbowne1 version of implementation with more implementations done

In the find_best_fit function on line number 111. There's a null pointer error. In the statement `if (!best_fit

Karutoh commented on pull request Karutoh/CustomHeapManager#4 2024-02-14 15:19:38 -08:00
gbowne1 version of implementation with more implementations done

There's an additional ALIGN16 macro function call in fragment_block function which is unnecessary.

Karutoh commented on pull request Karutoh/CustomHeapManager#4 2024-02-14 15:10:50 -08:00
gbowne1 version of implementation with more implementations done

I noticed on line #34 there's an issue. You've done s += BLOCK_SIZE;. This not ideal and should only hold the size of data the memory block contains, not including the memory block header.…

Karutoh commented on pull request Karutoh/CustomHeapManager#4 2024-02-14 15:05:45 -08:00
gbowne1 version of implementation with more implementations done

Seems a alignment of 16 bytes is indeed required of x64 architectures.