Revert "Project modernization (#630)"
This code was not tested and breaks in Release builds, reverting to restore
functionality of the nightly. All in-game menus do not work and generating
a world crashes.
This reverts commit a9be52c41a.
This commit is contained in:
@@ -25,31 +25,31 @@ MerchantRecipe *MerchantRecipeList::getRecipeFor(shared_ptr<ItemInstance> buyA,
|
||||
{
|
||||
// attempt to match vs the hint
|
||||
MerchantRecipe *r = m_recipes.at(selectionHint);
|
||||
if (buyA->id == r->getBuyAItem()->id && ((buyB == nullptr && !r->hasSecondaryBuyItem()) || (r->hasSecondaryBuyItem() && buyB != nullptr && r->getBuyBItem()->id == buyB->id)))
|
||||
if (buyA->id == r->getBuyAItem()->id && ((buyB == NULL && !r->hasSecondaryBuyItem()) || (r->hasSecondaryBuyItem() && buyB != NULL && r->getBuyBItem()->id == buyB->id)))
|
||||
{
|
||||
if (buyA->count >= r->getBuyAItem()->count && (!r->hasSecondaryBuyItem() || buyB->count >= r->getBuyBItem()->count))
|
||||
{
|
||||
return r;
|
||||
}
|
||||
}
|
||||
return nullptr;
|
||||
return NULL;
|
||||
}
|
||||
for (size_t i = 0; i < m_recipes.size(); i++)
|
||||
for (int i = 0; i < m_recipes.size(); i++)
|
||||
{
|
||||
MerchantRecipe *r = m_recipes.at(i);
|
||||
if (buyA->id == r->getBuyAItem()->id && buyA->count >= r->getBuyAItem()->count
|
||||
&& ((!r->hasSecondaryBuyItem() && buyB == nullptr) || (r->hasSecondaryBuyItem() && buyB != nullptr && r->getBuyBItem()->id == buyB->id && buyB->count >= r->getBuyBItem()->count)))
|
||||
&& ((!r->hasSecondaryBuyItem() && buyB == NULL) || (r->hasSecondaryBuyItem() && buyB != NULL && r->getBuyBItem()->id == buyB->id && buyB->count >= r->getBuyBItem()->count)))
|
||||
{
|
||||
return r;
|
||||
}
|
||||
}
|
||||
return nullptr;
|
||||
return NULL;
|
||||
}
|
||||
|
||||
bool MerchantRecipeList::addIfNewOrBetter(MerchantRecipe *recipe)
|
||||
{
|
||||
bool added = false;
|
||||
for (size_t i = 0; i < m_recipes.size(); i++)
|
||||
for (int i = 0; i < m_recipes.size(); i++)
|
||||
{
|
||||
MerchantRecipe *r = m_recipes.at(i);
|
||||
if (recipe->isSame(r))
|
||||
@@ -69,32 +69,32 @@ bool MerchantRecipeList::addIfNewOrBetter(MerchantRecipe *recipe)
|
||||
|
||||
MerchantRecipe *MerchantRecipeList::getMatchingRecipeFor(shared_ptr<ItemInstance> buy, shared_ptr<ItemInstance> buyB, shared_ptr<ItemInstance> sell)
|
||||
{
|
||||
for (size_t i = 0; i < m_recipes.size(); i++)
|
||||
for (int i = 0; i < m_recipes.size(); i++)
|
||||
{
|
||||
MerchantRecipe *r = m_recipes.at(i);
|
||||
if (buy->id == r->getBuyAItem()->id && buy->count >= r->getBuyAItem()->count && sell->id == r->getSellItem()->id)
|
||||
{
|
||||
if (!r->hasSecondaryBuyItem() || (buyB != nullptr && buyB->id == r->getBuyBItem()->id && buyB->count >= r->getBuyBItem()->count))
|
||||
if (!r->hasSecondaryBuyItem() || (buyB != NULL && buyB->id == r->getBuyBItem()->id && buyB->count >= r->getBuyBItem()->count))
|
||||
{
|
||||
return r;
|
||||
}
|
||||
}
|
||||
}
|
||||
return nullptr;
|
||||
return NULL;
|
||||
}
|
||||
|
||||
void MerchantRecipeList::writeToStream(DataOutputStream *stream)
|
||||
{
|
||||
stream->writeByte(static_cast<byte>(m_recipes.size() & 0xff));
|
||||
for (size_t i = 0; i < m_recipes.size(); i++)
|
||||
stream->writeByte((byte) (m_recipes.size() & 0xff));
|
||||
for (int i = 0; i < m_recipes.size(); i++)
|
||||
{
|
||||
MerchantRecipe *r = m_recipes.at(i);
|
||||
Packet::writeItem(r->getBuyAItem(), stream);
|
||||
Packet::writeItem(r->getSellItem(), stream);
|
||||
|
||||
shared_ptr<ItemInstance> buyBItem = r->getBuyBItem();
|
||||
stream->writeBoolean(buyBItem != nullptr);
|
||||
if (buyBItem != nullptr)
|
||||
stream->writeBoolean(buyBItem != NULL);
|
||||
if (buyBItem != NULL)
|
||||
{
|
||||
Packet::writeItem(buyBItem, stream);
|
||||
}
|
||||
@@ -149,7 +149,7 @@ CompoundTag *MerchantRecipeList::createTag()
|
||||
CompoundTag *tag = new CompoundTag();
|
||||
|
||||
ListTag<CompoundTag> *list = new ListTag<CompoundTag>(L"Recipes");
|
||||
for (size_t i = 0; i < m_recipes.size(); i++)
|
||||
for (int i = 0; i < m_recipes.size(); i++)
|
||||
{
|
||||
MerchantRecipe *merchantRecipe = m_recipes.at(i);
|
||||
list->add(merchantRecipe->createTag());
|
||||
|
||||
Reference in New Issue
Block a user