Revert "Project modernization (#630)"
This code was not tested and breaks in Release builds, reverting to restore
functionality of the nightly. All in-game menus do not work and generating
a world crashes.
This reverts commit a9be52c41a.
This commit is contained in:
@@ -23,7 +23,7 @@ shared_ptr<Entity> EntityDamageSource::getEntity()
|
||||
|
||||
shared_ptr<ChatPacket> EntityDamageSource::getDeathMessagePacket(shared_ptr<LivingEntity> player)
|
||||
{
|
||||
shared_ptr<ItemInstance> held = (entity != nullptr) && entity->instanceof(eTYPE_LIVINGENTITY) ? dynamic_pointer_cast<LivingEntity>(entity)->getCarriedItem() : nullptr;
|
||||
shared_ptr<ItemInstance> held = (entity != NULL) && entity->instanceof(eTYPE_LIVINGENTITY) ? dynamic_pointer_cast<LivingEntity>(entity)->getCarriedItem() : nullptr;
|
||||
wstring additional = L"";
|
||||
|
||||
if (entity->instanceof(eTYPE_SERVERPLAYER))
|
||||
@@ -39,19 +39,19 @@ shared_ptr<ChatPacket> EntityDamageSource::getDeathMessagePacket(shared_ptr<Livi
|
||||
}
|
||||
}
|
||||
|
||||
if ( (held != nullptr) && held->hasCustomHoverName())
|
||||
if ( (held != NULL) && held->hasCustomHoverName())
|
||||
{
|
||||
return std::make_shared<ChatPacket>(player->getNetworkName(), m_msgWithItemId, entity->GetType(), additional, held->getHoverName());
|
||||
return shared_ptr<ChatPacket>( new ChatPacket(player->getNetworkName(), m_msgWithItemId, entity->GetType(), additional, held->getHoverName() ) );
|
||||
}
|
||||
else
|
||||
{
|
||||
return std::make_shared<ChatPacket>(player->getNetworkName(), m_msgId, entity->GetType(), additional);
|
||||
return shared_ptr<ChatPacket>( new ChatPacket(player->getNetworkName(), m_msgId, entity->GetType(), additional ) );
|
||||
}
|
||||
}
|
||||
|
||||
bool EntityDamageSource::scalesWithDifficulty()
|
||||
{
|
||||
return (entity != nullptr) && entity->instanceof(eTYPE_LIVINGENTITY) && !entity->instanceof(eTYPE_PLAYER);
|
||||
return (entity != NULL) && entity->instanceof(eTYPE_LIVINGENTITY) && !entity->instanceof(eTYPE_PLAYER);
|
||||
}
|
||||
|
||||
// 4J: Copy function
|
||||
|
||||
Reference in New Issue
Block a user