Revert "Project modernization (#630)"
This code was not tested and breaks in Release builds, reverting to restore
functionality of the nightly. All in-game menus do not work and generating
a world crashes.
This reverts commit a9be52c41a.
This commit is contained in:
@@ -23,7 +23,7 @@ UIScene_InGameInfoMenu::UIScene_InGameInfoMenu(int iPad, void *initData, UILayer
|
||||
{
|
||||
INetworkPlayer *player = g_NetworkManager.GetPlayerByIndex( i );
|
||||
|
||||
if( player != nullptr )
|
||||
if( player != NULL )
|
||||
{
|
||||
PlayerInfo *info = BuildPlayerInfo(player);
|
||||
|
||||
@@ -36,7 +36,7 @@ UIScene_InGameInfoMenu::UIScene_InGameInfoMenu(int iPad, void *initData, UILayer
|
||||
|
||||
INetworkPlayer *thisPlayer = g_NetworkManager.GetLocalPlayerByUserIndex( m_iPad );
|
||||
m_isHostPlayer = false;
|
||||
if(thisPlayer != nullptr) m_isHostPlayer = thisPlayer->IsHost() == TRUE;
|
||||
if(thisPlayer != NULL) m_isHostPlayer = thisPlayer->IsHost() == TRUE;
|
||||
|
||||
Minecraft *pMinecraft = Minecraft::GetInstance();
|
||||
shared_ptr<MultiplayerLocalPlayer> localPlayer = pMinecraft->localplayers[m_iPad];
|
||||
@@ -109,7 +109,7 @@ void UIScene_InGameInfoMenu::updateTooltips()
|
||||
{
|
||||
keyA = IDS_TOOLTIPS_SELECT;
|
||||
}
|
||||
else if( selectedPlayer != nullptr)
|
||||
else if( selectedPlayer != NULL)
|
||||
{
|
||||
bool editingHost = selectedPlayer->IsHost();
|
||||
if( (cheats && (m_isHostPlayer || !editingHost ) ) || (!trust && (m_isHostPlayer || !editingHost))
|
||||
@@ -134,7 +134,7 @@ void UIScene_InGameInfoMenu::updateTooltips()
|
||||
if(!m_buttonGameOptions.hasFocus())
|
||||
{
|
||||
// if the player is me, then view gamer profile
|
||||
if(selectedPlayer != nullptr && selectedPlayer->IsLocal() && selectedPlayer->GetUserIndex()==m_iPad)
|
||||
if(selectedPlayer != NULL && selectedPlayer->IsLocal() && selectedPlayer->GetUserIndex()==m_iPad)
|
||||
{
|
||||
ikeyY = IDS_TOOLTIPS_VIEW_GAMERPROFILE;
|
||||
}
|
||||
@@ -172,7 +172,7 @@ void UIScene_InGameInfoMenu::handleReload()
|
||||
{
|
||||
INetworkPlayer *player = g_NetworkManager.GetPlayerByIndex( i );
|
||||
|
||||
if( player != nullptr )
|
||||
if( player != NULL )
|
||||
{
|
||||
PlayerInfo *info = BuildPlayerInfo(player);
|
||||
|
||||
@@ -183,7 +183,7 @@ void UIScene_InGameInfoMenu::handleReload()
|
||||
|
||||
INetworkPlayer *thisPlayer = g_NetworkManager.GetLocalPlayerByUserIndex( m_iPad );
|
||||
m_isHostPlayer = false;
|
||||
if(thisPlayer != nullptr) m_isHostPlayer = thisPlayer->IsHost() == TRUE;
|
||||
if(thisPlayer != NULL) m_isHostPlayer = thisPlayer->IsHost() == TRUE;
|
||||
|
||||
Minecraft *pMinecraft = Minecraft::GetInstance();
|
||||
shared_ptr<MultiplayerLocalPlayer> localPlayer = pMinecraft->localplayers[m_iPad];
|
||||
@@ -209,7 +209,7 @@ void UIScene_InGameInfoMenu::tick()
|
||||
{
|
||||
INetworkPlayer *player = g_NetworkManager.GetPlayerByIndex( i );
|
||||
|
||||
if(player != nullptr)
|
||||
if(player != NULL)
|
||||
{
|
||||
PlayerInfo *info = BuildPlayerInfo(player);
|
||||
|
||||
@@ -283,7 +283,7 @@ void UIScene_InGameInfoMenu::handleInput(int iPad, int key, bool repeat, bool pr
|
||||
if(pressed && m_playerList.hasFocus() && (m_playerList.getItemCount() > 0) && (m_playerList.getCurrentSelection() < m_players.size()) )
|
||||
{
|
||||
INetworkPlayer *player = g_NetworkManager.GetPlayerBySmallId(m_players[m_playerList.getCurrentSelection()]->m_smallId);
|
||||
if( player != nullptr )
|
||||
if( player != NULL )
|
||||
{
|
||||
PlayerUID uid = player->GetUID();
|
||||
if( uid != INVALID_XUID )
|
||||
@@ -327,14 +327,14 @@ void UIScene_InGameInfoMenu::handleInput(int iPad, int key, bool repeat, bool pr
|
||||
|
||||
void UIScene_InGameInfoMenu::handlePress(F64 controlId, F64 childId)
|
||||
{
|
||||
app.DebugPrintf("Pressed = %d, %d\n", static_cast<int>(controlId), static_cast<int>(childId));
|
||||
switch(static_cast<int>(controlId))
|
||||
app.DebugPrintf("Pressed = %d, %d\n", (int)controlId, (int)childId);
|
||||
switch((int)controlId)
|
||||
{
|
||||
case eControl_GameOptions:
|
||||
ui.NavigateToScene(m_iPad,eUIScene_InGameHostOptionsMenu);
|
||||
break;
|
||||
case eControl_GamePlayers:
|
||||
int currentSelection = static_cast<int>(childId);
|
||||
int currentSelection = (int)childId;
|
||||
INetworkPlayer *selectedPlayer = g_NetworkManager.GetPlayerBySmallId(m_players[currentSelection]->m_smallId);
|
||||
|
||||
Minecraft *pMinecraft = Minecraft::GetInstance();
|
||||
@@ -344,7 +344,7 @@ void UIScene_InGameInfoMenu::handlePress(F64 controlId, F64 childId)
|
||||
bool cheats = app.GetGameHostOption(eGameHostOption_CheatsEnabled) != 0;
|
||||
bool trust = app.GetGameHostOption(eGameHostOption_TrustPlayers) != 0;
|
||||
|
||||
if( isOp && selectedPlayer != nullptr)
|
||||
if( isOp && selectedPlayer != NULL)
|
||||
{
|
||||
bool editingHost = selectedPlayer->IsHost();
|
||||
if( (cheats && (m_isHostPlayer || !editingHost ) ) || (!trust && (m_isHostPlayer || !editingHost))
|
||||
@@ -377,10 +377,10 @@ void UIScene_InGameInfoMenu::handlePress(F64 controlId, F64 childId)
|
||||
|
||||
void UIScene_InGameInfoMenu::handleFocusChange(F64 controlId, F64 childId)
|
||||
{
|
||||
switch(static_cast<int>(controlId))
|
||||
switch((int)controlId)
|
||||
{
|
||||
case eControl_GamePlayers:
|
||||
m_playerList.updateChildFocus( static_cast<int>(childId) );
|
||||
m_playerList.updateChildFocus( (int) childId );
|
||||
};
|
||||
updateTooltips();
|
||||
}
|
||||
@@ -389,7 +389,7 @@ void UIScene_InGameInfoMenu::OnPlayerChanged(void *callbackParam, INetworkPlayer
|
||||
{
|
||||
app.DebugPrintf("<UIScene_InGameInfoMenu::OnPlayerChanged> Player \"%ls\" %s (smallId: %d)\n", pPlayer->GetOnlineName(), leaving ? "leaving" : "joining", pPlayer->GetSmallId());
|
||||
|
||||
UIScene_InGameInfoMenu *scene = static_cast<UIScene_InGameInfoMenu *>(callbackParam);
|
||||
UIScene_InGameInfoMenu *scene = (UIScene_InGameInfoMenu *)callbackParam;
|
||||
bool playerFound = false;
|
||||
int foundIndex = 0;
|
||||
for(int i = 0; i < scene->m_players.size(); ++i)
|
||||
@@ -439,7 +439,7 @@ void UIScene_InGameInfoMenu::OnPlayerChanged(void *callbackParam, INetworkPlayer
|
||||
|
||||
int UIScene_InGameInfoMenu::KickPlayerReturned(void *pParam,int iPad,C4JStorage::EMessageResult result)
|
||||
{
|
||||
BYTE smallId = *static_cast<BYTE *>(pParam);
|
||||
BYTE smallId = *(BYTE *)pParam;
|
||||
delete pParam;
|
||||
|
||||
if(result==C4JStorage::EMessage_ResultAccept)
|
||||
@@ -448,7 +448,7 @@ int UIScene_InGameInfoMenu::KickPlayerReturned(void *pParam,int iPad,C4JStorage:
|
||||
shared_ptr<MultiplayerLocalPlayer> localPlayer = pMinecraft->localplayers[iPad];
|
||||
if(localPlayer->connection)
|
||||
{
|
||||
localPlayer->connection->send(std::make_shared<KickPlayerPacket>(smallId));
|
||||
localPlayer->connection->send( shared_ptr<KickPlayerPacket>( new KickPlayerPacket(smallId) ) );
|
||||
}
|
||||
}
|
||||
|
||||
@@ -473,7 +473,7 @@ UIScene_InGameInfoMenu::PlayerInfo *UIScene_InGameInfoMenu::BuildPlayerInfo(INet
|
||||
}
|
||||
|
||||
int voiceStatus = 0;
|
||||
if(player != nullptr && player->HasVoice() )
|
||||
if(player != NULL && player->HasVoice() )
|
||||
{
|
||||
if( player->IsMutedByLocalUser(m_iPad) )
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user